[Bug 1055005] Review Request: system-config-repo - Administrate a single yum repository file.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1055005



--- Comment #2 from Sergio Pascual <sergio.pasra@xxxxxxxxx> ---
Problems (blocker)
===================

* Naming: according to the guidelines[1] a snapshot package has a release tage
of the form "date-of-checkout vcs-name commit-id". In your case something like
20140120gitc112d69

In addition, depending if the package is a pre relase or a post release, the
full version must be:

# pre release
Release: 0.1.%{checkout}%{?dist}

# post release
Release: 1.%{checkout}%{?dist}

where checkout is

%global checkout 20140120git%{shortcommit}

Your package is a pre release, isn't it?


* Python requires and bytecompiling: your package is python 3 based but the
python sources are installed in a private directory. Some of the things RPM
does for packages under python system directories aren't done (properly),
namely:

 - bytecompilling [2], RPM is using python 2.7 to generate the .pyc and .pyo of
your package. If you define  

 %global __python %{__python3}

  RPM will use python3 for bytecompilling

 - Python 3 runtime, your package does not have a Requires on python3. It's
generated automatically for packages under python system directory. I haven't
found a better way than an explicit 
  Requires: python(abi) = 3.3

* Directories: if your package requires sudo to run (and I think it does), it
should Require it. That way /etc/sudoers.d is not unowned
  Requires: sudo

Non blocker
===========

I think primarely is a typo, I have only found "primarily" in my english
dictionary.


[1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
[2] https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]