[Bug 728302] Review Request: pjproject - Libraries written in C language for building embedded/non-embedded VoIP applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=728302

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx



--- Comment #65 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
Just some "drive-by" comments:

- The --prefix= in the call below is redundant to %configure
%configure --prefix=%{_prefix}    \

It doesn't hurt, but it can be removed.


- You are shipping static libs:
 %{_libdir}/*.a

These are multiply problematic.

1. Shipping static libs is strongly discouraged in Fedora.
Please read: 
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries

2. Their naming is weird naming, which technically reduces their applicability.

3. Static libs MUST be shipped in a *-static subpackage and not in *-devel


- %doc contains superflous documents:
README-RTEMS is not of any relevance to Fedora users and INSTALL.txt is not of
use to users of Fedora packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]