https://bugzilla.redhat.com/show_bug.cgi?id=1005782 Michael Simacek <msimacek@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |msimacek@xxxxxxxxxx Flags| |fedora-review? --- Comment #8 from Michael Simacek <msimacek@xxxxxxxxxx> --- (In reply to gil cattaneo from comment #7) > (In reply to Michael Simacek from comment #6) > > Few issues before doing in-depth review: > > - icons are licensed under BSD (according to LICENSE file) -> License should > > be ASL 2.0 and BSD > > maybe ASL 2.0 or BSD ... ? Dual licensing means that you (as a user of library) can choose between the two licenses and only one of them applies. But his license is not dual - this are just two licenses that each apply to different parts of the sw, but they both apply at the same time - you can't choose just one. Actual quote from the guidelines: "Note that this only applies when the contents of the package are actually under a dual license, and not when the package contains items under multiple, distinct, and independent licenses" If it were a dual license it would be explicitly stated. (Still don't know about the other license mentioned in NOTICE, though) > > Those scripts suggest that some parts could be directly executed by user. > > Why don't you install them or (better) provide %jpackage_script alternatives? > > Unavailable libraries > e.g. > UIMA_CLASSPATH=$UIMA_CLASSPATH:$UIMA_HOME/lib/uimaj-as-core.jar > UIMA_CLASSPATH=$UIMA_CLASSPATH:$UIMA_HOME/lib/uimaj-as-activemq.jar > UIMA_CLASSPATH=$UIMA_CLASSPATH:$UIMA_HOME/lib/uimaj-as-jms.jar > available @ > http://www.apache.org/dist/uima/uima-as-2.4.2/uima-as-2.4.2-source-release. > zip > > and others ... > for now, until all deps aren't available, i prefer don't install script files > or systemd support Does this affect any other part of the package? -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review