https://bugzilla.redhat.com/show_bug.cgi?id=1005782 --- Comment #7 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Michael Simacek from comment #6) > Few issues before doing in-depth review: > - icons are licensed under BSD (according to LICENSE file) -> License should > be ASL 2.0 and BSD maybe ASL 2.0 or BSD ... ? https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Dual_Licensing_Scenarios > - there is a NOTICE file, which could possibly affect packages licensing. > I sent an email to Fedora legal mailing-list to get this sorted out. Thanks! > > some rpmlint warnings: > uimaj.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/uimaj/NOTICE > uimaj.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/uimaj/README > jcasgen-maven-plugin.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/jcasgen-maven-plugin/NOTICE > uima-pear-maven-plugin.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/uima-pear-maven-plugin/NOTICE > uimaj-javadoc.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/uimaj-javadoc/NOTICE Fixed > > > And a few questions: > Why do you remove that "eclipse stuff"? You should include a reason in the > comment above it. eclipse stuff dont provides pom or depmap files... > Why do you remove apache-rat-plugin? Build @ random fails > Those scripts suggest that some parts could be directly executed by user. > Why don't you install them or (better) provide %jpackage_script alternatives? Unavailable libraries e.g. UIMA_CLASSPATH=$UIMA_CLASSPATH:$UIMA_HOME/lib/uimaj-as-core.jar UIMA_CLASSPATH=$UIMA_CLASSPATH:$UIMA_HOME/lib/uimaj-as-activemq.jar UIMA_CLASSPATH=$UIMA_CLASSPATH:$UIMA_HOME/lib/uimaj-as-jms.jar available @ http://www.apache.org/dist/uima/uima-as-2.4.2/uima-as-2.4.2-source-release.zip and others ... for now, until all deps aren't available, i prefer don't install script files or systemd support Spec URL: http://gil.fedorapeople.org/uimaj.spec SRPM URL: http://gil.fedorapeople.org/uimaj-2.5.0-1.fc19.src.rpm - fix license field - fix wrong-file-end-of-line-encoding -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review