[Bug 1016887] Review Request: mingw-c-ares - A library for asynchronous DNS operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1016887



--- Comment #1 from Sandro Mani <manisandro@xxxxxxxxx> ---
Looks good! Two comments:
- licensecheck lists MIT, BSD and ISC. So I'd suggest License should read:

# ares_getopt.c ares_getopt.h are BSD (3 clause)
# bitncmp.c inet_net_pton.c inet_ntop.c are ISC
# rest is MIT
License: MIT and BSD and ISC

- (Curiosity) Why are you generating and shipping the def file?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]