[Bug 1001799] Review Request: kbarcode - A barcode and label printing application for KDE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1001799



--- Comment #13 from Antonio Trande <anto.trande@xxxxxxxxx> ---
(In reply to Mario Blättermann from comment #12)
> (In reply to Antonio Trande from comment #11)
> > - Compiler works on files with different licenses; in particular
> > src/barkode.cpp file is licensed with a LGPLv2+, all the others with a
> > GPLv2+. 
> > This is a "Mixed Source Licensing Scenario"
> > http://fedoraproject.org/wiki/Packaging:
> > LicensingGuidelines#Mixed_Source_Licensing_Scenario
> > 
> > - %build does not honor applicable compiler flags
> >
> What do you mean? The %cmake_kde4 macro is the usual way for KDE software.
> It expands to:
> 
> $ rpm --eval %cmake_kde4
> 
>   QTDIR="/usr/lib64/qt4" ; export QTDIR ; 
>   PATH="/usr/lib64/qt4/bin:$PATH" ; export PATH ; 
>   CFLAGS="${CFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
> -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches 
> -m64 -mtune=generic}" ; export CFLAGS ; 
>   CXXFLAGS="${CXXFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
> -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
> -grecord-gcc-switches  -m64 -mtune=generic}" ; export CXXFLAGS ; 
>   FFLAGS="${FFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
> -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches 
> -m64 -mtune=generic -I/usr/lib64/gfortran/modules}" ; export FFLAGS ; 
>   LDFLAGS="${LDFLAGS:--Wl,-z,relro }" ; export LDFLAGS ; 
>   /usr/bin/cmake \
>     -DBUILD_SHARED_LIBS:BOOL=ON \
>     -DCMAKE_BUILD_TYPE=release \
>     -DCMAKE_INSTALL_PREFIX:PATH=/usr \
>     -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON \
>     -DDATA_INSTALL_DIR:PATH=/usr/share/kde4/apps \
>     -DINCLUDE_INSTALL_DIR:PATH=/usr/include/kde4 \
>     -DLIB_INSTALL_DIR:PATH=/usr/lib64 \
>     -DKDE4_BUILD_TESTS:BOOL=OFF \
> %if "lib64" == "lib64" 
>      -DLIB_SUFFIX=64 \
> %endif 
>     -DLIBEXEC_INSTALL_DIR:PATH=/usr/libexec/kde4 \
>     -DSYSCONF_INSTALL_DIR:PATH=/etc
>  

You're right but they are not utilized as build.log shows:

...
[ 10%] Building CXX object src/CMakeFiles/kbarcode.dir/barkodeengine.o
cd /builddir/build/BUILD/kbarcode/x86_64-redhat-linux-gnu/src &&
/usr/lib64/ccache/c++   -DKDE4_CMAKE_TOPLEVEL_DIR_LENGTH=21
-DKDE_DEPRECATED_WARNINGS -DQT_NO_CAST_TO_ASCII -DQT_NO_STL -D_BSD_SOURCE
-D_REENTRANT -D_XOPEN_SOURCE=500 -g -Wall -O2 -DNDEBUG -DQT_NO_DEBUG
-I/builddir/build/BUILD/kbarcode/x86_64-redhat-linux-gnu/src
-I/builddir/build/BUILD/kbarcode/src -I/builddir/build/BUILD/kbarcode
-I/builddir/build/BUILD/kbarcode/src/dialogs -I/usr/include/kde4
-I/usr/include/kde4/KDE -I/usr/include/KDE -I/usr/include/phonon
-I/usr/include/QtXmlPatterns -I/usr/include/QtXml -I/usr/include/QtWebKit
-I/usr/include/QtUiTools -I/usr/include/QtTest -I/usr/include/QtSvg
-I/usr/include/QtSql -I/usr/include/QtScriptTools -I/usr/include/QtScript
-I/usr/include/QtOpenGL -I/usr/include/QtNetwork -I/usr/include/QtMultimedia
-I/usr/include/QtHelp -I/usr/include/QtDesigner -I/usr/include/QtDeclarative
-I/usr/include/QtDBus -I/usr/include/Qt3Support -I/usr/include/QtGui
-I/usr/include/QtCore -I/usr/include/Qt -I/usr/lib64/qt4/mkspecs/default   
-D_GNU_SOURCE -D_LARGEFILE64_SOURCE -o CMakeFiles/kbarcode.dir/barkodeengine.o
-c /builddir/build/BUILD/kbarcode/src/barkodeengine.cpp
/usr/bin/cmake -E cmake_progress_report
/builddir/build/BUILD/kbarcode/x86_64-redhat-linux-gnu/CMakeFiles 7
...

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]