https://bugzilla.redhat.com/show_bug.cgi?id=1001799 --- Comment #12 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- (In reply to Antonio Trande from comment #11) > - Compiler works on files with different licenses; in particular > src/barkode.cpp file is licensed with a LGPLv2+, all the others with a > GPLv2+. > This is a "Mixed Source Licensing Scenario" > http://fedoraproject.org/wiki/Packaging: > LicensingGuidelines#Mixed_Source_Licensing_Scenario > > - %build does not honor applicable compiler flags > What do you mean? The %cmake_kde4 macro is the usual way for KDE software. It expands to: $ rpm --eval %cmake_kde4 QTDIR="/usr/lib64/qt4" ; export QTDIR ; PATH="/usr/lib64/qt4/bin:$PATH" ; export PATH ; CFLAGS="${CFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic}" ; export CFLAGS ; CXXFLAGS="${CXXFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic}" ; export CXXFLAGS ; FFLAGS="${FFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -I/usr/lib64/gfortran/modules}" ; export FFLAGS ; LDFLAGS="${LDFLAGS:--Wl,-z,relro }" ; export LDFLAGS ; /usr/bin/cmake \ -DBUILD_SHARED_LIBS:BOOL=ON \ -DCMAKE_BUILD_TYPE=release \ -DCMAKE_INSTALL_PREFIX:PATH=/usr \ -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON \ -DDATA_INSTALL_DIR:PATH=/usr/share/kde4/apps \ -DINCLUDE_INSTALL_DIR:PATH=/usr/include/kde4 \ -DLIB_INSTALL_DIR:PATH=/usr/lib64 \ -DKDE4_BUILD_TESTS:BOOL=OFF \ %if "lib64" == "lib64" -DLIB_SUFFIX=64 \ %endif -DLIBEXEC_INSTALL_DIR:PATH=/usr/libexec/kde4 \ -DSYSCONF_INSTALL_DIR:PATH=/etc > - Don't mix the buildroot tags (${RPM_BUILD_ROOT}/%{buildroot}) > OK, now I'm using %{buildroot} only. > - Also fix these lines > %{buildroot}/%{_datadir}/kde4/apps/%{name}/barcode.ps > %{buildroot}/%{_datadir}/kde4/apps/%{name}/barcode.ps > ${RPM_BUILD_ROOT}/%{_datadir}/applications/kde4/%{name}.desktop > > there are extra slashes. Removed. Moreover, I've moved the "b3" tag to "Release:" according to the special guidelines for pre-release packages. See https://lists.fedoraproject.org/pipermail/packaging/2013-November/009824.html. New files: Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/kbarcode.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/kbarcode-3.0.0-0.1.b3.fc20.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review