[Bug 1010557] Review Request: numix-gtk-theme - Numix GTK theme for Gnome, Xfce and Openbox

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1010557



--- Comment #13 from Satyajit Sahoo <satyajit.happy@xxxxxxxxx> ---
Hi. I don't know how to find a sponsor. It'll be great if someone can find me
one.

1. Remove Group tag as it's not used by Fedora as MUST.

---> Done.

2. You'd better use http://numixproject.org/ as URL of the RPM but not a URL
shortten service shortlink.

---> The short-link was not a URL shorten service, rather than the deviantArt
page, anyways I changed it to http://numixproject.org

3. %install

 - 1. First, %{__install} --> install

 ---> Done.

 - 2. Second,

      Please use install command to copy them via install -pm644.

 ---> Sorry, but the install command cannot install directories and only files.
So I cannot use it here.

4. This package should be renamed to numix-themes, thus the dependencies looks
agreeable:

---> Done.

I first thought this package was this one:

https://github.com/numixproject/numix-icon-theme

---> The package name numix-gtk-theme doesn't certainly refer to
numix-icon-theme, but I changed it to numix-themes anyways.

Here are the new links,

http://satya164.fedorapeople.org/numix-themes/numix-themes.spec
http://satya164.fedorapeople.org/numix-themes/numix-themes-2.1-1.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]