[Bug 1010557] Review Request: numix-gtk-theme - Numix GTK theme for Gnome, Xfce and Openbox

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1010557



--- Comment #12 from Christopher Meng <cickumqt@xxxxxxxxx> ---
Please find a sponsor, otherwise you may never be able to package anything to
Fedora...(Not taunt)

1. Remove Group tag as it's not used by Fedora as MUST.

2. You'd better use http://numixproject.org/ as URL of the RPM but not a URL
shortten service shortlink.

3. %install
%{__install} -d -m755 %{buildroot}%{_datadir}/themes/%{theme}
for file in gtk-2.0 gtk-3.0 metacity-1 openbox-3 unity xfce-notify-4.0 xfwm4
index.theme; do
    %{__cp} -a ${file} %{buildroot}%{_datadir}/themes/%{theme}
done

 - 1. First, %{__install} --> install

 - 2. Second,

for file in gtk-2.0 gtk-3.0 metacity-1 openbox-3 unity xfce-notify-4.0 xfwm4
index.theme; do
    %{__cp} -a ${file} %{buildroot}%{_datadir}/themes/%{theme}
done

Please use install command to copy them via install -pm644.

4. This package should be renamed to numix-themes, thus the dependencies looks
agreeable:

Requires:    numix-common
Requires:    numix-gtk2-theme
Requires:    numix-gtk3-theme
Requires:    numix-metacity-theme
Requires:    numix-openbox-theme
Requires:    numix-xfce-notify-theme
Requires:    numix-xfwm4-theme

I first thought this package was this one:

https://github.com/numixproject/numix-icon-theme

But then I found I was wrong... So be careful on choosing names.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]