https://bugzilla.redhat.com/show_bug.cgi?id=1047111 --- Comment #6 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- (In reply to Remi Collet from comment #5) > [!]: Requires correct, justified where necessary. > From composer.json > "symfony/console": "~2.0" > "symfony/yaml": "~2.1", > So you can't use %{symfony_min_ver} for both All Symfony components require each other's version so they should all be in-sync version-wise and it simplifies this spec to just take the ceiling of the minimum version. > [!]: Dist tag is present (not strictly required in GL). Fixed > Cosmetic: > => sed xxx foo > bar (instead of cat) > => install -pm 755 ... Updated > Please review %description to match changes in php-doctrine-cache (no > sub-packages) Updated > About /usr/bin/doctrine. > > Instead of creating a PSR-0 autoloader, I think it will be cleaner to use > Doctrine one (as in the doctrine-dbal command). > > require_once '/usr/share/php/Doctrine/Common/ClassLoader.php'; > $classLoader = new \Doctrine\Common\ClassLoader('Doctrine'); > $classLoader->register(); > $classLoader = new \Doctrine\Common\ClassLoader('Symfony'); > $classLoader->register(); Updated. Much nicer. THANKS! Updates: - Conditional %%{?dist} - Bin script patch instead of inline update and use Doctrine Common classloader - Updated optional cache information in %%description - Removed empty file - Removed unnecessary executable bit Diff: https://github.com/siwinski/rpms/compare/9872cb2f77b8146ae4709ca1fd7f7e83c500910f...66d248d6ca984af2e696a993adcaef0d1efc81c6 Spec URL: https://raw.github.com/siwinski/rpms/66d248d6ca984af2e696a993adcaef0d1efc81c6/php-doctrine-orm.spec SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-doctrine-orm-2.4.1-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review