https://bugzilla.redhat.com/show_bug.cgi?id=1047111 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #5 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- [!] Package installs properly. Ok, with all the new doctrine stack [!]: Requires correct, justified where necessary. From composer.json "symfony/console": "~2.0" "symfony/yaml": "~2.1", So you can't use %{symfony_min_ver} for both [!]: Dist tag is present (not strictly required in GL). Cosmetic: => sed xxx foo > bar (instead of cat) => install -pm 755 ... Please review %description to match changes in php-doctrine-cache (no sub-packages) About /usr/bin/doctrine. Instead of creating a PSR-0 autoloader, I think it will be cleaner to use Doctrine one (as in the doctrine-dbal command). require_once '/usr/share/php/Doctrine/Common/ClassLoader.php'; $classLoader = new \Doctrine\Common\ClassLoader('Doctrine'); $classLoader->register(); $classLoader = new \Doctrine\Common\ClassLoader('Symfony'); $classLoader->register(); First test for upgrade path seems ok :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review