https://bugzilla.redhat.com/show_bug.cgi?id=1047647 --- Comment #3 from Ben Reedy <thebenj88@xxxxxxxxx> --- spec file is in the same location SRPM is located at http://breed808.com/rpmfusion-submission/libchardet-1.0.2-3.fc20.src.rpm (In reply to Christopher Meng from comment #2) Thank you for the help, Christopher. >1. Group tag is not a MUST HAVE tag now, you can drop it on your own. > >2. These 2 lines are not needed: > >Packager: Ben Reedy <thebenj88@xxxxxxxxx> >BuildRequires: gcc-c++ Removed. > 3. Description and summary are the same, that's bad. Please improve. I've updated the description, though it is fairly short. I've had difficulty finding a valuable description for libchardet. > 4. Use macro: > > %configure > > instead of > > ./configure --prefix=%{_prefix} --sysconfdir=%{_sysconfdir} > --libdir=%{_libdir} \ > --mandir=%{_mandir} --disable-static Is it ok that I've added the '--disable-static' flag after the %configure macro? > Why did you add so many comments here? I don't think you need to write down > "this part below is Binary" as you are the packager, you MUST know their > usage, and we reviewer know them certainly as well. Agreed, I should have removed these some time ago. (In reply to MartinKG from comment #1) > Please insert each time you make a change an entry in the changelog and > increase also the Release number. + post the %changelog. > https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs Hi Martin, I've updated the changelog and release number. One question: the changelog guidelines mention that if a package has been updated but not built, the package's Release does not need to be incremented and a new entry can be added to the changelog. Does that apply for packages under review? https://fedoraproject.org/wiki/Packaging:Guidelines#Repeat_the_old_version_release_with_a_new_entry -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review