https://bugzilla.redhat.com/show_bug.cgi?id=1047647 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx --- Comment #2 from Christopher Meng <cickumqt@xxxxxxxxx> --- A dep of cmplayer, right? I can't sponsor you, but some thoughts: 1. Group tag is not a MUST HAVE tag now, you can drop it on your own. 2. These 2 lines are not needed: Packager: Ben Reedy <thebenj88@xxxxxxxxx> BuildRequires: gcc-c++ 3. Description and summary are the same, that's bad. Please improve. 4. Use macro: %configure instead of ./configure --prefix=%{_prefix} --sysconfdir=%{_sysconfdir} --libdir=%{_libdir} \ --mandir=%{_mandir} --disable-static 5. %files # Libraries %{_libdir}/%{name}.so.* # Man pages %{_mandir}/ko/man3/* # We don't want the libtool archive %exclude %{_libdir}/%{name}.la %files devel #Binary %{_bindir}/chardet-config # Header files %{_includedir}/chardet/ # Development library %{_libdir}/%{name}.so # Documentation %doc README LICENSE Changelog Why did you add so many comments here? I don't think you need to write down "this part below is Binary" as you are the packager, you MUST know their usage, and we reviewer know them certainly as well. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review