https://bugzilla.redhat.com/show_bug.cgi?id=1047596 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ fedora-cvs- --- Comment #2 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- Small notes: - version have no sense for such package, but we are used to take the rest version (so 1.3). BuildRequires: php-pear >= 1:1.4.9-1.2 => minimal version have no more sense (RHEL-4 is EOL) mixed-use-of-spaces-and-tabs => trivial, could be fixed on import. As this channel provides a lot of extensions which already exists in standard pear channel (probably all are not packaged) we should be very carefull with each package, to check file conflicts, in peardir, docdir, ... I will try to go forward on the other reviews. A possible solution could be to set a specific pear_phpdir, pear_docdir, pear_testdir... for this channel (so in the %post of this package). but I hope this is not required and we can go without. No blocker. === APPROVED === -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review