[Bug 1046842] Review Request: python-ofxparse - Python library for working with the Open Financial Exchange file format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1046842

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Mock build successful for rawhide x86_64

+ rpmlint on generated rpms is
python3-ofxparse.noarch: W: spelling-error %description -l en_US ofx -> fox,
of, ox
python-ofxparse.noarch: W: spelling-error %description -l en_US ofx -> fox, of,
ox
python-ofxparse.src: W: spelling-error %description -l en_US ofx -> fox, of, ox
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ Source verified with upstream as (sha256sum)
upstream tarball:
d8c486126a94d912442d040121db44fbc4a646ea70fa935df33b5b4dbfbbe42a
srpm tarball: d8c486126a94d912442d040121db44fbc4a646ea70fa935df33b5b4dbfbbe42a

+ License is valid and included in LICENSE file

Suggestions:
1) I will not block this review for %{python_sitelib} which should have been
written as %{python2_sitelib} and same for %{__python} to %{__python2}

you can check these python2 macros are already on the system
/etc/rpm/macros.python2

but you should use python2 macros actually.


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]