https://bugzilla.redhat.com/show_bug.cgi?id=823351 --- Comment #13 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> --- Hi Julian, I've made some adjustments to the spec file and pushed the changes to a Git repo, here: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-yajl-ruby.git/log/ I've broken each change into a separate Git commit so you can review each one. I'll also try to explain each suggested change below. 1. (60bdf07) remove gem2rpm autogenerated comment. The gem2rpm tool inserts this comment into the packages, but it is just cruft so we can remove it. 2. (233f9b0) use HTTPS in URLs. This commit changes the URL from using plaintext HTTP to secured HTTPS. 3. (f054c1c) remove trailing whitespace. There were two lines with trailing whitespace in the spec file, so this commit fixes that. 4. (27bddfb) simplify el6/rubyabi conditionals. The last Fedora version that supported ruby(abi) is Fedora 18, and this is going end-of-life in a few days. We only need to support ruby(abi) on EL6. This commit simplifies the RPM dist conditionals to reflect this. 5. (a9e8c12) build doc subpackage as noarch. The -doc subpackage should be set to "noarch" since there's no architecture-specific files within it. 6. (c6cb71d) move build process into %build. The Ruby guidelines indicate that the gem should be unpacked in %prep and built in %build. This commit runs "gem unpack" and "gem spec" in %prep, and "gem build" in %build. 7. (2abbc85) use %gem_install macro. On platforms that are not EL6, the %gem_install macro is available and preferable to manually compiling the gem. 8. (2b748f8) use %{ruby_sitearch} and %{gem_extdir_mri}. The %{gem_extdir} macro is deprecated. Use %{ruby_sitearch} on EL6, and use %{gem_extdir_mri} elsewhere. 9. (a2de3a8) BuildRequire ruby(rubygems). I needed to add this to get the package to build on EL6. 10. (031261f) mark README.md and CHANGELOG.md as %doc. These files are text, not code, so I marked them as such in this commit. 11. (8f5c851) move README.md to main package. I thought it would be a good idea to ship this in the main package because so that it's more accessible to users. 12. (1e3db58) delete unnecessary gemspec during %install. It's not necessary to ship two gemspecs for this package. This commit deletes the duplicate during %install. 13. (128ca61) remove developer-only files during %prep. Some files were deleted during %install, some files were %exclude'd, and some were shipped in -doc. This commit just deletes them all during %prep (and removes them from the gemspec) for cleanliness and consistency. I've tested this version on EL6 and F19, and simple JSON tests work on both platforms. -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review