https://bugzilla.redhat.com/show_bug.cgi?id=1044607 --- Comment #3 from Susi Lehtola <susi.lehtola@xxxxxx> --- (In reply to Antonio Trande from comment #2) > Hi Susi. > > - I don't see any License file in the sources although all files are > released with a 'BSD (3 clause)' license according to their headers. > I think you should include a License text. > http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text Adding license texts separate from upstream is explicitly forbidden. And asking upstream to add the text is a SHOULD. > - Why are you using the %_qt4_qmake macro instead of %{_qt4_qmake} ? Well, these are the same thing, the {} doesn't do anything here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review