https://bugzilla.redhat.com/show_bug.cgi?id=1010512 --- Comment #9 from Timothy St. Clair <tstclair@xxxxxxxxxx> --- [!]: Package requires other packages for directories it uses. mesos-devel should own %{includedir}/mesos. Currently stout and libprocess are in there as well, but these probably shouldn't be. [!]: Package must own all directories that it creates. as above >[!]: Package contains no bundled libraries without FPC exception. > leveldb, stout, and libprocess are all available from separate upstreams > (stout and leveldb are already in Fedora). If you can justify exceptions > (seems likely for stout and possible for libprocess?), then apply for them; > otherwise, mesos will need to be patched to use system copies. Other bundled > libraries in 3rdparty should be removed before building. Both stout and libprocess breakout <> subsuming were a result of numerous conversations with upstream. Originally BenH had intended for them to exist as separate entities, but they were so tightly coupled with the root project that the canonical source is the mesos project. The "resolution" that made the most sense was instead to kill off the separate packages before they hit a distribution, as they are not versioned independently of mesos. However, a compromise was to create sub-packages to allow folks to use the libraries. I supposed I could leave the sub-package breakout in the .spec and just have a mesos-devel. From everyone's perspective is much more simple, should the desire exist to breakout sub-packages for other reasons, the plumbing will exist. leveldb should not exist, it was likely a result from a merged update. >[!]: Sources contain only permissible code or content. > as above re: bundled libs >[!]: Package is not known to require an ExcludeArch tag. > Please comment the ExcludeArch with justification. Sources contain code which currently do not compile on arm, and upstream has no explicit intent to support + not all dependencies exist iirc. >[!]: Uses parallel make %{?_smp_mflags} macro. > not a blocker, but please justify in a spec comment why it isn't there. Currently not capable with upstream >[!]: %check is present and all tests pass. > Tests skipped due to problems in mock; not a blocker Tests fail in mock, but succeed outside, some are intermittent. >[!]: Spec use %global instead of %define unless justified. > Please use %global throughout. -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review