Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Pugs-Compiler-Rule - Compiler for Perl 6 Rules https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231085 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium ------- Additional Comments From panemade@xxxxxxxxx 2007-03-27 03:16 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url ce75b08a0b2a294502492c3423ae165f Pugs-Compiler-Rule-0.20.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test Skip blib/lib/Pugs/Emitter/Rule/Perl5/Ratchet.pm (unchanged) Skip blib/lib/Pugs/Grammar/Rule2.pm (unchanged) Skip blib/lib/Pugs/Compiler/Regex.pm (unchanged) Skip blib/lib/Pugs/Runtime/Match/HsBridge.pm (unchanged) Skip blib/lib/Pugs/Runtime/Match.pm (unchanged) Skip blib/lib/Pugs/Compiler/Rule.pm (unchanged) Skip blib/lib/Pugs/Runtime/Common.pm (unchanged) Skip blib/lib/Pugs/Grammar/Rule.pm (unchanged) Skip blib/lib/Pugs/Emitter/Rule/Perl5.pm (unchanged) Skip blib/lib/Pugs/Runtime/Regex.pm (unchanged) Skip blib/lib/Pugs/Grammar/Rule.pmc (unchanged) Skip blib/lib/Pugs/Grammar/Precedence.pm (unchanged) Skip blib/lib/Pugs/Compiler/Token.pm (unchanged) Skip blib/lib/Pugs/Grammar/Base.pm (unchanged) Skip blib/lib/Pugs/Runtime/Rule.pm (unchanged) Skip blib/lib/Pugs/Compiler/RegexPerl5.pm (unchanged) PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t t/01-iterator_engine....ok t/02-grammar............ok t/03-match..............ok t/04-rule...............ok t/05-var................ok t/06-subrule............ok 2/33 skipped: various reasons t/08-hash...............ok t/09-ratchet............ok t/10-regex_perl5........ok t/11-quantifier.........ok All tests successful, 2 subtests skipped. Files=10, Tests=358, 9 wallclock secs ( 6.75 cusr + 0.30 csys = 7.05 CPU) + Provides: perl(Pugs::Compiler::Regex) perl(Pugs::Compiler::RegexPerl5) perl(Pugs::Compiler::Rule) perl(Pugs::Compiler::Token) perl(Pugs::Emitter::Rule::Perl5) perl(Pugs::Emitter::Rule::Perl5::Ratchet) perl(Pugs::Grammar::Base) perl(Pugs::Grammar::Rule) perl(Pugs::Runtime::Common) perl(Pugs::Runtime::Match) perl(Pugs::Runtime::Match::HsBridge) perl(Pugs::Runtime::Regex) perl(Pugs::Runtime::Rule) Why make test skipped? Is that one expected one or I am missing anything? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review