https://bugzilla.redhat.com/show_bug.cgi?id=1040459 --- Comment #4 from Dan Fruehauf <malkodan@xxxxxxxxx> --- (In reply to Simon Farnsworth from comment #3) > Down to a couple of nitpick level comments, which are as likely to be proof > of my ignorance as anything else: > > * Patch0's comment - could it include a link to your upstream submission as > described in > https://fedoraproject.org/wiki/Packaging: > Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment ? I've sent an email to the maintainer, unfortunately there's no upstream bugzilla for that... > > * You still Require: gtk3, when autorequires will pull it in; is there a > reason to do this? Similarly, do you need the UI for gnome-keyring and CLI > tools for dbus, or just the libraries that autorequires pull in? My > understanding of > https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires is > that you shouldn't put Require: lines in if autorequires pulls in enough. Yep, you're right, it's just unnecessary clutter. Removed. > > If I've misunderstood something, please correct me - I'm new at this. > > Oh, and if you've got any spare time, a review of bug 1034341 would be > appreciated. I'm going to review it now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review