[Bug 1040459] Review Request: NetworkManager-iodine - iodine VPN plugin for NetworkManager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1040459



--- Comment #3 from Simon Farnsworth <simon@xxxxxxxxxxxx> ---
Down to a couple of nitpick level comments, which are as likely to be proof of
my ignorance as anything else:

 * Patch0's comment - could it include a link to your upstream submission as
described in
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment
?

 * You still Require: gtk3, when autorequires will pull it in; is there a
reason to do this? Similarly, do you need the UI for gnome-keyring and CLI
tools for dbus, or just the libraries that autorequires pull in? My
understanding of
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires is that
you shouldn't put Require: lines in if autorequires pulls in enough.

If I've misunderstood something, please correct me - I'm new at this.

Oh, and if you've got any spare time, a review of bug 1034341 would be
appreciated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]