https://bugzilla.redhat.com/show_bug.cgi?id=1040517 --- Comment #2 from Milan Bouchet-Valat <nalimilan@xxxxxxx> --- Thanks for the reply. I've updated the files linked above with a revised .spec and .src.rpm. I have renamed julia to julia-base and made julia a metapackage depending on julia-base and julia-doc, to follow what R currently does. I figured in the future it could become more important when some essential packages could be installed by default for most users. Please tell me whether you think it's right. (In reply to Christopher Meng from comment #1) > Drop-by: > > 1. ExclusiveArch has i386 only? > > Please do this from command line: > > rpm -E %{ix86} Woops, obviously I meant that. I couldn't find a list of architectures until you gave me this macro. > 2. Group: Applications/Engineering > > Fedora now doesn't need it as a MUST, you can drop it if you want. Yeah, but I figured it couldn't hurt. As you prefer. > 3. # .gitignore files make rpmlint complain > find . -name ".git*" -exec rm {} \; > > Please tell upstream don't include such files in the tarball Yeah, another issue I'm going to file. This is because upstream does not really make tarballs at the moment, they merely mark git commits as the release. > 4. %{buildroot}/usr > > Please use %{_prefix} for /usr. > > And I've sent a patch to upstream. So you mean use %{buildroot}/%{_prefix}? Indeed, I've done that now. > 5. %SYSCONFDIR=/etc > > Please use macro %{_sysconfdir} Done. > And did you consider seriously why you still have to run "mv > %{buildroot}/usr/etc/ %{buildroot}/etc"? I think %SYSCONFDIR=/etc doesn't > work, please try to fix the errors from your part, and try again. Yeah, I said upstream that their Makefile is currently broken. It always installs to $PREFIX/etc, as Makefile explains: # Note that we don't install to SYSCONFDIR: we always install to PREFIX/etc. # If you want to make a distribution with a hardcoded path, you take care of installation My goal is to get rid of this kind of ugly hacks for the next release. > 6. /usr/%{_lib} > > --> > > %{_libdir} Done. > 7. Is it a MUST? > > ln -s julia.1.gz julia-basic.1.gz > ln -s julia.1.gz julia-readline.1.gz > ln -s julia.1.gz julia-debug-basic.1.gz > ln -s julia.1.gz julia-debug-readline.1.gz Not sure, rpmlint complains when manpages are missing, and this may still be useful. I've got a change accepted upstream to ship those files in the future. > 8. It's better to add soname to these libraries. You mean, to libjulia.so? (Others are only for internal use.) Indeed it would make sense, but I'd rather wait for upstream to do that -- I think they do not consider the API/ABI stable at this point. Do you think I should call the file libjulia.so.0 anyway? > 9. %files section: > > %{_datadir}/man/man1/julia.1.gz > > Please use macro, and also a glob to let RPM determine if the manpages are > compressed already or not: > > %{_mandir}/man1/julia.1* Nice trick! > 10. %post devel -p /sbin/ldconfig > %postun devel -p /sbin/ldconfig > > Please put above lines before %files. Done. > 11. Please leave a blank line between each changelog, this will help some > people not keen-eyed. Done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review