[Bug 1040517] Review Request: julia - High-level, high-performance dynamic language for technical computing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1040517



--- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> ---
Drop-by:

1. ExclusiveArch has i386 only?

Please do this from command line:

rpm -E %{ix86}

2. Group:          Applications/Engineering 

Fedora now doesn't need it as a MUST, you can drop it if you want.

3. # .gitignore files make rpmlint complain
find . -name ".git*" -exec rm {} \;

Please tell upstream don't include such files in the tarball

4. %{buildroot}/usr

Please use %{_prefix} for /usr.

And I've sent a patch to upstream.

5. %SYSCONFDIR=/etc

Please use macro %{_sysconfdir}

And did you consider seriously why you still have to run "mv
%{buildroot}/usr/etc/ %{buildroot}/etc"? I think %SYSCONFDIR=/etc doesn't work,
please try to fix the errors from your part, and try again.

6. /usr/%{_lib}

-->

%{_libdir}

7. Is it a MUST?

ln -s julia.1.gz julia-basic.1.gz
ln -s julia.1.gz julia-readline.1.gz
ln -s julia.1.gz julia-debug-basic.1.gz
ln -s julia.1.gz julia-debug-readline.1.gz

8. It's better to add soname to these libraries.

9. %files section:

%{_datadir}/man/man1/julia.1.gz

Please use macro, and also a glob to let RPM determine if the manpages are
compressed already or not:

%{_mandir}/man1/julia.1*

10. %post devel -p /sbin/ldconfig
%postun devel -p /sbin/ldconfig

Please put above lines before %files.

11. Please leave a blank line between each changelog, this will help some
people  not keen-eyed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]