https://bugzilla.redhat.com/show_bug.cgi?id=1031318 Ken Dreyer <ktdreyer@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #8 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> --- Thanks for addressing my questions. I still think the package should have a .desktop file, but I understand your reasoning for not doing shipping one at this time. Based on your responses, I don't see any remaining blockers, so package APPROVED. > > - Please filter /usr/bin/env from Provides. > - Well, I don't see "Provides" has /usr/bin/env. Would you check this? I'm wrong, sorry. It's in Requires rather than Provides. > > - What is the GPG file for? It seems to me that you could remove it from the > > binary packages, or else document the reason for its existence in the spec. > > - Well, I don't think we have to dare to remove this file... It just seems odd that Fedora ships a file without anyone understanding the purpose for doing so, particularly something security-related like a GPG key. I can't find a reason myself, so I'll defer to you as the package's maintainer. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review