https://bugzilla.redhat.com/show_bug.cgi?id=1031318 --- Comment #7 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- Thank you for comments! Before I modify my package: (In reply to Ken Dreyer from comment #6) > - The rabbirc command requires the net-irc Gem, and it will crash without it. > I'm thinking you should remove rabbirc from the package until we can ship > that Gem in Fedora. (It looks like net-irc has not had any updates in four > years, by the way :( - I will remove this for now > - The Debian logos at /usr/share/gems/gems/rabbit-2.1.1/data/rabbit/ are > technically LGPLv3+ or CC-BY. See > http://www.debian.org/logos/index.en.html#open-use - Well, rabbbit git history says that this logos were added 3 years ago, while debian (swirl) logo relicensing happened at least after 2012: http://lists.debian.org/debian-doc/2012/08/msg00044.html The original license was effectively MIT: http://ftp-master.metadata.debian.org/changelogs/main/d/desktop-base/desktop-base_6.0.5squeeze1_copyright And "debian" character logo is under this license. > - lib/rabbit/trackball.rb looks to be under the MIT license. - The whole rabbit license is under GPLv2+ (except for artificial image files, some of them are under CC-BY), and we don't have to write "weaker" licenses than GPL: https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#What_is_.22effective_license.22_and_do_I_need_to_know_that_for_the_License:_tag.3F > - /usr/bin/rabbit needs a corresponding .desktop file. - rabbit always needs .rd files or so as its argument, just launching rabbit without argument just launches file selection GUI, so I don't think desktop file is needed. (maybe mimetype registration can be used - however I think using some file manager and using "Open with this program" will suffice.) > - When I ran /usr/bin/rabbit from a terminal with a PDF file as an argument, > it > printed out a message: > [INFO] > Installing gem: rabbit-theme-questionnaire > The PDF did have the word "Questionnaire" in its filename. Maybe that > triggered this? > At any rate, it looks like the software (lib/rabbit/gem-finder.rb) tries to > automatically install things into Gem.dir. After I ran rabbit I couldn't > find > a rabbit-theme-questionnaire in my Gem.dir, but I'm thinking you might want > to patch that part out that part of the code to be safe. - First of all, (while file selection seems to show pdf files as selection entry), I don't know well rabbit handles pdf, so I want to hold it as it is for now (needs investigating) > The rest of the issues are not blocking, just suggestions: > > - I love the BothRequires macro :) Can you make it %global rather than > %define? - For function (parameterized macro), it seems that %define is safer: https://lists.fedoraproject.org/pipermail/packaging/2009-May/006035.html > - Please filter /usr/bin/env from Provides. - Well, I don't see "Provides" has /usr/bin/env. Would you check this? > - You can remove the "generated by gem2rpm" comment at the top of the spec > file. - Will remove next time > - The spec file comments indicate that the zero-length files might be left in > intentionally. What is the purpose of the zero-length files? Can you please > document this in the spec? - Just it is unclear to me this I can _really_ remove these files (as I have already seen that removing zero files really caused problems...) so unless it becomes clear for me, I want to leave these as they are. > - What is the GPG file for? It seems to me that you could remove it from the > binary packages, or else document the reason for its existence in the spec. - Well, I don't think we have to dare to remove this file... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review