https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #20 from Branislav Blaškovič <bblaskov@xxxxxxxxxx> --- Spec URL: http://blaskovic.fedorapeople.org/fedora-gooey-karma/fedora-gooey-karma.spec SRPM URL: http://blaskovic.fedorapeople.org/fedora-gooey-karma/fedora-gooey-karma-0.1-2.fc20.src.rpm (In reply to Miroslav Suchý from comment #19) > Can you please post link to your latest SPEC and SRC.RPM? Oh, I see you are > still updating the same files. Please do not do that. Every change - even if > it is just your own and it does not reach Fedora - every change which your > copy to web, please bump up release (and make entry in changelog). Ok, attaching latest SRPM, bumping release and adding note to changelog. > Or not? Because for example the last issue from #17 (file permissions) is > still not fixed. I can see this fixed. If you are talking about /usr/share/fedora-gooey-karma/* files. Please check it in the newest package. > Please include python2-devel > https://fedoraproject.org/wiki/Packaging:Python#BuildRequires > Or python3-devel -- which would be even nice, because Fedora now tries to > move to python3 as default. python2-devel included. Thank you > rm -rf %{buildroot} > is not needed unless you want to build for EPEL. Removed. > Please use full commit URL for SOURCE0. See: > http://fedoraproject.org/wiki/Packaging:SourceURL#Github Changed. Thank you for this Github trick. I missed it while reading wikis. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review