[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1020839



--- Comment #19 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
Can you please post link to your latest SPEC and SRC.RPM? Oh, I see you are
still updating the same files. Please do not do that. Every change - even if it
is just your own and it does not reach Fedora - every change which your copy to
web, please bump up release (and make entry in changelog).

Or not? Because for example the last issue from #17 (file permissions) is still
not fixed.

Please include python2-devel
https://fedoraproject.org/wiki/Packaging:Python#BuildRequires
Or python3-devel -- which would be even nice, because Fedora now tries to move
to python3 as default.

rm -rf %{buildroot}
is not needed unless you want to build for EPEL.

Please use full commit URL for SOURCE0. See:
http://fedoraproject.org/wiki/Packaging:SourceURL#Github

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]