https://bugzilla.redhat.com/show_bug.cgi?id=1016803 --- Comment #18 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Christoph Wickert from comment #17) Hi Christoph. Thanks for your reply. > Kevin, who is the package owner already said he is fine with > rodent-icon-theme replacing xfce4-icon theme. So am I, but I suggest you > only do this in Fedora >= 20 and not in the released versions. Okay. Let's go with replacing. > > This however requires a few more changes: > > - Completely obsolete/provide xfce4-icon-theme as per > https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming. > 2FReplacing_Existing_Packages > > - You need to own all of %{_datadir}/icons/rodent/ > You need to own this directory anyway, because with two packages that do not > Done. I hope it's fine. > - Replace it in comps, too. See > https://fedoraproject.org/wiki/How_to_use_and_edit_comps. > xml_for_package_groups I presume that it must be done when package will be approved. > > - If you completely replace xfce4-icon-theme, you can simply use > %{_datadir}/icons/Rodent/ instead of %{_datadir}/icons/rodent/ > rodent-icon-theme now owns %{_datadir}/icons/Rodent/. > > General remarks: > > - Instead of: > sed -e 's|Rodent|rodent|g' -i Makefile.in > sed -e 's|Rodent|rodent|g' -i scalable/*/Makefile.in > you can simply use: > sed -e 's|Rodent|rodent|g' -i Makefile.in scalable/*/Makefile.in rodent-icon-theme replaces xcfe4-icon-theme so these commands are not useful anymore. > > - Please preserve timestamps during %prep and %install, see > https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps > > To preserve the timestamps during iconv conversion, see second example from > https://fedoraproject.org/wiki/Packaging_tricks#Convert_encoding_to_UTF-8 > > To preserve timestamps during %install, please change > make install DESTDIR=$RPM_BUILD_ROOT > to > make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p' Done. > > - The scriptlets create the icon theme cache, so you need to include it as > %ghost %{_datadir}/icons/rodent/icon-theme.cache > See > http://www.rpm.org/max-rpm-snapshot/s1-rpm-inside-files-list-directives.html > Done. Spec URL: http://sagitter.fedorapeople.org/rodent-icon-theme/rodent-icon-theme.spec SRPM URL: http://sagitter.fedorapeople.org/rodent-icon-theme/rodent-icon-theme-5.0-3.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review