https://bugzilla.redhat.com/show_bug.cgi?id=1016803 Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(cwickert@fedorapr | |oject.org) | --- Comment #17 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> --- Kevin, who is the package owner already said he is fine with rodent-icon-theme replacing xfce4-icon theme. So am I, but I suggest you only do this in Fedora >= 20 and not in the released versions. This however requires a few more changes: - Completely obsolete/provide xfce4-icon-theme as per https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages - You need to own all of %{_datadir}/icons/rodent/ You need to own this directory anyway, because with two packages that do not - Replace it in comps, too. See https://fedoraproject.org/wiki/How_to_use_and_edit_comps.xml_for_package_groups - If you completely replace xfce4-icon-theme, you can simply use %{_datadir}/icons/Rodent/ instead of %{_datadir}/icons/rodent/ General remarks: - Instead of: sed -e 's|Rodent|rodent|g' -i Makefile.in sed -e 's|Rodent|rodent|g' -i scalable/*/Makefile.in you can simply use: sed -e 's|Rodent|rodent|g' -i Makefile.in scalable/*/Makefile.in - Please preserve timestamps during %prep and %install, see https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps To preserve the timestamps during iconv conversion, see second example from https://fedoraproject.org/wiki/Packaging_tricks#Convert_encoding_to_UTF-8 To preserve timestamps during %install, please change make install DESTDIR=$RPM_BUILD_ROOT to make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p' - The scriptlets create the icon theme cache, so you need to include it as %ghost %{_datadir}/icons/rodent/icon-theme.cache See http://www.rpm.org/max-rpm-snapshot/s1-rpm-inside-files-list-directives.html The rest looks fine and I trust Christopher enough to finish this review. Thanks everybody! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review