[Bug 1014738] Review Request: python-astropy - A Community Python Library for Astronomy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1014738



--- Comment #23 from Christian Dersch <chrisdersch@xxxxxxxxx> ---
Hi,

I performed another (right now informal) review, looks fine imho :) As I'm new
to reviewing
packages, I'm unsure about some points (marked with [?] => not evaluated).

Greetings,
Christian


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[?]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "BSD (3 clause)", "BSD (2 clause)", "Unknown or generated". 425 files
     have unknown license. Detailed output of licensecheck in
     /home/rpmbuild/1014738-python-astropy/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-
     astropy-doc , python3-astropy , python3-astropy-doc , python3-astropy-
     devel , astropy-tools
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[?]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python-astropy-0.3-1.fc21.x86_64.rpm
          python-astropy-doc-0.3-1.fc21.noarch.rpm
          python-astropy-devel-0.3-1.fc21.x86_64.rpm
          python3-astropy-0.3-1.fc21.x86_64.rpm
          python3-astropy-doc-0.3-1.fc21.noarch.rpm
          python3-astropy-devel-0.3-1.fc21.x86_64.rpm
          astropy-tools-0.3-1.fc21.noarch.rpm
          python-astropy-0.3-1.fc21.src.rpm
python-astropy.x86_64: W: spelling-error %description -l en_US asciitable ->
ascertainable
python-astropy.x86_64: W: spelling-error %description -l en_US photometric ->
photo metric, photo-metric, photometer
python-astropy.x86_64: E: zero-length
/usr/lib64/python2.7/site-packages/astropy/utils/tests/data/test_package/data/foo.txt
python-astropy-devel.x86_64: W: no-documentation
python3-astropy.x86_64: W: spelling-error %description -l en_US asciitable ->
ascertainable
python3-astropy.x86_64: W: spelling-error %description -l en_US photometric ->
photo metric, photo-metric, photometer
python3-astropy.x86_64: E: zero-length
/usr/lib64/python3.3/site-packages/astropy/utils/tests/data/test_package/data/foo.txt
python3-astropy-devel.x86_64: W: no-documentation
astropy-tools.noarch: W: no-documentation
astropy-tools.noarch: W: no-manual-page-for-binary volint
astropy-tools.noarch: W: no-manual-page-for-binary wcslint
python-astropy.src: W: spelling-error %description -l en_US vo -> co, vi, v
python-astropy.src: W: spelling-error %description -l en_US asciitable ->
ascertainable
python-astropy.src: W: spelling-error %description -l en_US photometric ->
photo metric, photo-metric, photometer
python-astropy.src:165: W: macro-in-comment %{__python3}
8 packages and 0 specfiles checked; 2 errors, 13 warnings.

==> Should be ok




Rpmlint (installed packages)
----------------------------
# rpmlint python-astropy python3-astropy python3-astropy-doc python-astropy-doc
astropy- 
tools python3-astropy-devel python-astropy-devel
python-astropy.x86_64: W: spelling-error %description -l en_US asciitable ->
ascertainable
python-astropy.x86_64: W: spelling-error %description -l en_US photometric ->
photo metric, photo-metric, photometer
python-astropy.x86_64: E: zero-length
/usr/lib64/python2.7/site-packages/astropy/utils/tests/data/test_package/data/foo.txt
python3-astropy.x86_64: W: spelling-error %description -l en_US asciitable ->
ascertainable
python3-astropy.x86_64: W: spelling-error %description -l en_US photometric ->
photo metric, photo-metric, photometer
python3-astropy.x86_64: E: zero-length
/usr/lib64/python3.3/site-packages/astropy/utils/tests/data/test_package/data/foo.txt
astropy-tools.noarch: W: no-documentation
astropy-tools.noarch: W: no-manual-page-for-binary volint
astropy-tools.noarch: W: no-manual-page-for-binary wcslint
python3-astropy-devel.x86_64: W: no-documentation
python-astropy-devel.x86_64: W: no-documentation
7 packages and 0 specfiles checked; 2 errors, 9 warnings.
# echo 'rpmlint-done:'

==> Should be ok


Requires
--------
python-astropy (rpmlib, GLIBC filtered):
    /usr/bin/xmllint
    h5py
    libc.so.6()(64bit)
    libcfitsio.so.1()(64bit)
    liberfa.so.1()(64bit)
    libexpat.so.1()(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libpython2.7.so.1.0()(64bit)
    libwcs.so.4()(64bit)
    numpy
    pytest
    python(abi)
    python-configobj
    python-six
    rtld(GNU_HASH)
    scipy

python3-astropy (rpmlib, GLIBC filtered):
    /usr/bin/xmllint
    libc.so.6()(64bit)
    libcfitsio.so.1()(64bit)
    liberfa.so.1()(64bit)
    libexpat.so.1()(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libpython3.3m.so.1.0()(64bit)
    libwcs.so.4()(64bit)
    python(abi)
    python3-configobj
    python3-h5py
    python3-numpy
    python3-pytest
    python3-scipy
    rtld(GNU_HASH)

python3-astropy-doc (rpmlib, GLIBC filtered):

python-astropy-doc (rpmlib, GLIBC filtered):

astropy-tools (rpmlib, GLIBC filtered):
    /usr/bin/python
    python-astropy

python3-astropy-devel (rpmlib, GLIBC filtered):
    python3-astropy(x86-64)

python-astropy-devel (rpmlib, GLIBC filtered):
    python-astropy(x86-64)



Provides
--------
python-astropy:
    python-astropy
    python-astropy(x86-64)

python3-astropy:
    python3-astropy
    python3-astropy(x86-64)

python3-astropy-doc:
    python3-astropy-doc

python-astropy-doc:
    python-astropy-doc

astropy-tools:
    astropy-tools

python3-astropy-devel:
    python3-astropy-devel
    python3-astropy-devel(x86-64)

python-astropy-devel:
    python-astropy-devel
    python-astropy-devel(x86-64)



Unversioned so-files
--------------------
python-astropy:
/usr/lib64/python2.7/site-packages/astropy/convolution/boundary_extend.so
python-astropy:
/usr/lib64/python2.7/site-packages/astropy/convolution/boundary_fill.so
python-astropy:
/usr/lib64/python2.7/site-packages/astropy/convolution/boundary_none.so
python-astropy:
/usr/lib64/python2.7/site-packages/astropy/convolution/boundary_wrap.so
python-astropy:
/usr/lib64/python2.7/site-packages/astropy/io/fits/compression.so
python-astropy:
/usr/lib64/python2.7/site-packages/astropy/io/votable/tablewriter.so
python-astropy: /usr/lib64/python2.7/site-packages/astropy/table/_np_utils.so
python-astropy: /usr/lib64/python2.7/site-packages/astropy/time/erfa_time.so
python-astropy: /usr/lib64/python2.7/site-packages/astropy/utils/_compiler.so
python-astropy:
/usr/lib64/python2.7/site-packages/astropy/utils/xml/_iterparser.so
python-astropy: /usr/lib64/python2.7/site-packages/astropy/wcs/_wcs.so
python3-astropy:
/usr/lib64/python3.3/site-packages/astropy/convolution/boundary_extend.cpython-33m.so
python3-astropy:
/usr/lib64/python3.3/site-packages/astropy/convolution/boundary_fill.cpython-33m.so
python3-astropy:
/usr/lib64/python3.3/site-packages/astropy/convolution/boundary_none.cpython-33m.so
python3-astropy:
/usr/lib64/python3.3/site-packages/astropy/convolution/boundary_wrap.cpython-33m.so
python3-astropy:
/usr/lib64/python3.3/site-packages/astropy/io/fits/compression.cpython-33m.so
python3-astropy:
/usr/lib64/python3.3/site-packages/astropy/io/votable/tablewriter.cpython-33m.so
python3-astropy:
/usr/lib64/python3.3/site-packages/astropy/table/_np_utils.cpython-33m.so
python3-astropy:
/usr/lib64/python3.3/site-packages/astropy/time/erfa_time.cpython-33m.so
python3-astropy:
/usr/lib64/python3.3/site-packages/astropy/utils/_compiler.cpython-33m.so
python3-astropy:
/usr/lib64/python3.3/site-packages/astropy/utils/xml/_iterparser.cpython-33m.so
python3-astropy:
/usr/lib64/python3.3/site-packages/astropy/wcs/_wcs.cpython-33m.so

==> Normal for python packages


Source checksums
----------------
http://pypi.python.org/packages/source/a/astropy/astropy-0.3.tar.gz :
  CHECKSUM(SHA256) this package     :
6c827ed074c1bc83fb0c8909f3c1293531e84a7920c9418747b75c676f60f2d6
  CHECKSUM(SHA256) upstream package :
6c827ed074c1bc83fb0c8909f3c1293531e84a7920c9418747b75c676f60f2d6


Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1014738
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api, C/C++
Disabled plugins: Java, SugarActivity, Perl, R, PHP, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]