[Bug 1035935] Review Request: mirrorbrain - A download redirector and metalink generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1035935



--- Comment #4 from Patrick Uiterwijk <puiterwijk@xxxxxxxxxx> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Permissions on files are set properly.
  Note: See rpmlint output
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
- Package contains BR: python2-devel or python3-devel
- Development (unversioned) .so files in -devel subpackage, if present.
  Note: mod_mirrorbrain.so and mod_autindex_mb.so are unversioned
- License file installed when any subpackage combination is installed.
  Note: subpackages do not require main package: 
- Sane buildrequires
  Note: Please don't BR files, but shadow-util, as described here:
https://fedoraproject.org/wiki/Packaging:UsersAndGroups
- If the package is under multiple licenses, the licensing breakdown must
  Note: I cannot see any brakdown of this
- Package must own all directories that it creates.
  Note: Please Require logrotate, httpd, etc
- %build honors applicable compiler flags or justifies otherwise.
  Note: Please add the %{optflags} to apxs
- Package consistently uses macros (instead of hard-coded directory names).
  Note: Package use both %{}-style and $-style variables
- Large documentation must go in a -doc subpackage. Large could be size
  Note: It would make sense to put "docs" and "sql" in a -doc subpacakge
- Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     mod_mirrorbrain , mod_autoindex_mb , mirrorbrain-tools , python-mb ,
     mirrorbrain-scanner

===== MUST items =====

Extra:
[!]: Sane buildrequires

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[!]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[!]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown must
     be documented in the spec.
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/httpd,
     /etc/logrotate.d, /usr/lib64/httpd/modules
[!]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 327680 bytes in 31 files.
[!]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     mod_mirrorbrain , mod_autoindex_mb , mirrorbrain-tools , python-mb ,
     mirrorbrain-scanner
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 1.1.33 starting...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Mock Version: 1.1.33
INFO: Mock Version: 1.1.33
Start: lock buildroot
INFO: installing package(s):
/home/redhat/puiterwi/Documents/Development/Fedora/Reviewing/mirrorbrain-2.17.0-1.fc20.x86_64.rpm
/home/redhat/puiterwi/Documents/Development/Fedora/Reviewing/mod_mirrorbrain-2.17.0-1.fc20.x86_64.rpm
/home/redhat/puiterwi/Documents/Development/Fedora/Reviewing/mod_autoindex_mb-2.17.0-1.fc20.x86_64.rpm
/home/redhat/puiterwi/Documents/Development/Fedora/Reviewing/mirrorbrain-tools-2.17.0-1.fc20.x86_64.rpm
/home/redhat/puiterwi/Documents/Development/Fedora/Reviewing/python-mb-2.17.0-1.fc20.x86_64.rpm
/home/redhat/puiterwi/Documents/Development/Fedora/Reviewing/mirrorbrain-scanner-2.17.0-1.fc20.x86_64.rpm
ERROR: Command failed: 
 # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-19-x86_64/root/',
'install',
'/home/redhat/puiterwi/Documents/Development/Fedora/Reviewing/mirrorbrain-2.17.0-1.fc20.x86_64.rpm',
'/home/redhat/puiterwi/Documents/Development/Fedora/Reviewing/mod_mirrorbrain-2.17.0-1.fc20.x86_64.rpm',
'/home/redhat/puiterwi/Documents/Development/Fedora/Reviewing/mod_autoindex_mb-2.17.0-1.fc20.x86_64.rpm',
'/home/redhat/puiterwi/Documents/Development/Fedora/Reviewing/mirrorbrain-tools-2.17.0-1.fc20.x86_64.rpm',
'/home/redhat/puiterwi/Documents/Development/Fedora/Reviewing/python-mb-2.17.0-1.fc20.x86_64.rpm',
'/home/redhat/puiterwi/Documents/Development/Fedora/Reviewing/mirrorbrain-scanner-2.17.0-1.fc20.x86_64.rpm',
'--setopt=tsflags=nocontexts']
Error: Package: mod_mirrorbrain-2.17.0-1.fc20.x86_64
(/mod_mirrorbrain-2.17.0-1.fc20.x86_64)
           Requires: apr-util-dbd-pgsql
 You could try using --skip-broken to work around the problem
Error: Package: mirrorbrain-scanner-2.17.0-1.fc20.x86_64
(/mirrorbrain-scanner-2.17.0-1.fc20.x86_64)
           Requires: perl(TimeDate)
Error: Package: mod_autoindex_mb-2.17.0-1.fc20.x86_64
(/mod_autoindex_mb-2.17.0-1.fc20.x86_64)
           Requires: apache-mod_mirrorbrain
Error: Package: mirrorbrain-tools-2.17.0-1.fc20.x86_64
(/mirrorbrain-tools-2.17.0-1.fc20.x86_64)
           Requires: python-cmdln
 You could try running: rpm -Va --nofiles --nodigest



Rpmlint
-------
Checking: mirrorbrain-2.17.0-1.fc20.x86_64.rpm
          mod_mirrorbrain-2.17.0-1.fc20.x86_64.rpm
          mod_autoindex_mb-2.17.0-1.fc20.x86_64.rpm
          mirrorbrain-tools-2.17.0-1.fc20.x86_64.rpm
          python-mb-2.17.0-1.fc20.x86_64.rpm
          mirrorbrain-scanner-2.17.0-1.fc20.x86_64.rpm
          mirrorbrain-2.17.0-1.el6.src.rpm
mirrorbrain.x86_64: W: spelling-error Summary(en_US) redirector -> re director,
re-director, redirect or
mirrorbrain.x86_64: W: spelling-error Summary(en_US) metalink -> meta link,
meta-link, metal ink
mirrorbrain.x86_64: W: spelling-error %description -l en_US apache -> Apache,
apace
mirrorbrain.x86_64: W: spelling-error %description -l en_US backend -> backed,
back end, back-end
mirrorbrain.x86_64: W: spelling-error %description -l en_US metalinks -> meta
links, meta-links, metal inks
mirrorbrain.x86_64: E: no-binary
mirrorbrain.x86_64: W: non-standard-uid /var/log/mirrorbrain mirrorbrain
mirrorbrain.x86_64: W: non-standard-gid /var/log/mirrorbrain mirrorbrain
mirrorbrain.x86_64: E: non-standard-dir-perm /var/log/mirrorbrain 0750L
mirrorbrain.x86_64: W: log-files-without-logrotate /var/log/mirrorbrain
mirrorbrain.x86_64: W: doc-file-dependency
/usr/share/doc/mirrorbrain/push2mirrors /usr/bin/python
mod_mirrorbrain.x86_64: W: spelling-error Summary(en_US) redirector -> re
director, re-director, redirect or
mod_mirrorbrain.x86_64: W: spelling-error %description -l en_US scalable ->
salable, callable, calculable
mod_mirrorbrain.x86_64: W: spelling-error %description -l en_US redirector ->
re director, re-director, redirect or
mod_mirrorbrain.x86_64: W: spelling-error %description -l en_US mirrorbrain ->
mirror brain, mirror-brain, brainstorming
mod_mirrorbrain.x86_64: W: invalid-license GPL
mod_mirrorbrain.x86_64: W: no-documentation
mod_mirrorbrain.x86_64: E: non-standard-executable-perm
/usr/lib64/httpd/modules/mod_mirrorbrain.so 0775L
mod_autoindex_mb.x86_64: W: spelling-error %description -l en_US autoindex ->
auto index, auto-index, autoimmune
mod_autoindex_mb.x86_64: W: spelling-error %description -l en_US mb -> MB, Mb,
m
mod_autoindex_mb.x86_64: W: spelling-error %description -l en_US metalink ->
meta link, meta-link, metal ink
mod_autoindex_mb.x86_64: W: spelling-error %description -l en_US mirrorlist ->
mirror list, mirror-list, moralist
mod_autoindex_mb.x86_64: W: invalid-license GPL
mod_autoindex_mb.x86_64: W: no-documentation
mod_autoindex_mb.x86_64: E: non-standard-executable-perm
/usr/lib64/httpd/modules/mod_autoindex_mb.so 0775L
mirrorbrain-tools.x86_64: W: spelling-error Summary(en_US) commandline ->
command line, command-line, commandment
mirrorbrain-tools.x86_64: W: spelling-error %description -l en_US scalable ->
salable, callable, calculable
mirrorbrain-tools.x86_64: W: spelling-error %description -l en_US redirector ->
re director, re-director, redirect or
mirrorbrain-tools.x86_64: W: invalid-license GPL
mirrorbrain-tools.x86_64: W: no-documentation
mirrorbrain-tools.x86_64: E: incoherent-logrotate-file
/etc/logrotate.d/mirrorprobe
mirrorbrain-tools.x86_64: E: executable-marked-as-config-file
/etc/logrotate.d/mirrorprobe
mirrorbrain-tools.x86_64: W: spurious-executable-perm
/etc/logrotate.d/mirrorprobe
mirrorbrain-tools.x86_64: W: no-manual-page-for-binary geoiplookup_city
mirrorbrain-tools.x86_64: W: no-manual-page-for-binary geoip-lite-update
mirrorbrain-tools.x86_64: W: no-manual-page-for-binary mirrorprobe
mirrorbrain-tools.x86_64: W: no-manual-page-for-binary bdecode
mirrorbrain-tools.x86_64: W: no-manual-page-for-binary rsyncusers
mirrorbrain-tools.x86_64: W: no-manual-page-for-binary create_timestamp
mirrorbrain-tools.x86_64: W: no-manual-page-for-binary metalink-hasher
mirrorbrain-tools.x86_64: W: no-manual-page-for-binary geoiplookup_continent
mirrorbrain-tools.x86_64: W: no-manual-page-for-binary null-rsync
mirrorbrain-tools.x86_64: W: no-manual-page-for-binary rsyncinfo
python-mb.x86_64: W: spelling-error Summary(en_US) commandline -> command line,
command-line, commandment
python-mb.x86_64: W: spelling-error %description -l en_US scalable -> salable,
callable, calculable
python-mb.x86_64: W: spelling-error %description -l en_US redirector -> re
director, re-director, redirect or
python-mb.x86_64: W: invalid-license GPL
python-mb.x86_64: W: no-documentation
python-mb.x86_64: E: non-executable-script
/usr/lib64/python2.7/site-packages/mb/mberr.py 0644L /usr/bin/python
python-mb.x86_64: E: non-executable-script
/usr/lib64/python2.7/site-packages/mb/countries.py 0644L /usr/bin/env
python-mb.x86_64: E: non-executable-script
/usr/lib64/python2.7/site-packages/mb/hashes.py 0644L /usr/bin/python
python-mb.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.7/site-packages/zsync.so 0775L
python-mb.x86_64: W: no-manual-page-for-binary mb
mirrorbrain-scanner.x86_64: W: spelling-error %description -l en_US scalable ->
salable, callable, calculable
mirrorbrain-scanner.x86_64: W: spelling-error %description -l en_US redirector
-> re director, re-director, redirect or
mirrorbrain-scanner.x86_64: W: invalid-license GPL
mirrorbrain-scanner.x86_64: W: no-documentation
mirrorbrain-scanner.x86_64: W: no-manual-page-for-binary scanner
mirrorbrain.src: W: spelling-error Summary(en_US) redirector -> re director,
re-director, redirect or
mirrorbrain.src: W: spelling-error Summary(en_US) metalink -> meta link,
meta-link, metal ink
mirrorbrain.src: W: spelling-error %description -l en_US apache -> Apache,
apace
mirrorbrain.src: W: spelling-error %description -l en_US backend -> backed,
back end, back-end
mirrorbrain.src: W: spelling-error %description -l en_US metalinks -> meta
links, meta-links, metal inks
mirrorbrain.src:72: W: mixed-use-of-spaces-and-tabs (spaces: line 72, tab: line
16)
7 packages and 0 specfiles checked; 10 errors, 54 warnings.




Requires
--------
python-mb (rpmlib, GLIBC filtered):
    /usr/bin/python
    geoip
    libc.so.6()(64bit)
    libpthread.so.0()(64bit)
    libpython2.7.so.1.0()(64bit)
    python(abi)
    python-psycopg2
    python-sqlobject
    rtld(GNU_HASH)

mirrorbrain-tools (rpmlib, GLIBC filtered):
    /bin/bash
    /usr/bin/env
    /usr/bin/python
    config(mirrorbrain-tools)
    geoip
    libGeoIP.so.1()(64bit)
    libc.so.6()(64bit)
    python-cmdln
    python-mb
    python-psycopg2
    python-sqlobject
    rtld(GNU_HASH)

mirrorbrain (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/python

mod_autoindex_mb (rpmlib, GLIBC filtered):
    apache-mod_mirrorbrain
    libc.so.6()(64bit)
    rtld(GNU_HASH)

mod_mirrorbrain (rpmlib, GLIBC filtered):
    apr-util-dbd-pgsql
    geoip
    httpd
    libc.so.6()(64bit)
    libm.so.6()(64bit)
    mod_form
    mod_geoip
    rtld(GNU_HASH)

mirrorbrain-scanner (rpmlib, GLIBC filtered):
    /usr/bin/perl
    perl(Config::IniFiles)
    perl(DBD::Pg)
    perl(DBI)
    perl(Data::Dumper)
    perl(Date::Parse)
    perl(Digest::MD4)
    perl(Encode)
    perl(LWP::UserAgent)
    perl(Net::Domain)
    perl(Net::FTP)
    perl(Socket)
    perl(Time::HiRes)
    perl(TimeDate)
    perl(bytes)
    perl(strict)
    perl-libwww-perl



Provides
--------
python-mb:
    python-mb
    python-mb(x86-64)

mirrorbrain-tools:
    config(mirrorbrain-tools)
    mirrorbrain-tools
    mirrorbrain-tools(x86-64)

mirrorbrain:
    mirrorbrain
    mirrorbrain(x86-64)

mod_autoindex_mb:
    mod_autoindex_mb
    mod_autoindex_mb(x86-64)

mod_mirrorbrain:
    mod_mirrorbrain
    mod_mirrorbrain(x86-64)

mirrorbrain-scanner:
    mirrorbrain-scanner
    mirrorbrain-scanner(x86-64)



Unversioned so-files
--------------------
mod_mirrorbrain: /usr/lib64/httpd/modules/mod_mirrorbrain.so
mod_autoindex_mb: /usr/lib64/httpd/modules/mod_autoindex_mb.so
python-mb: /usr/lib64/python2.7/site-packages/zsync.so

Source checksums
----------------
http://mirrorbrain.org/files/releases/mirrorbrain-2.17.0.tar.gz :
  CHECKSUM(SHA256) this package     :
5edabb76e10c24a44559ef7c52de24c2003860929926a6fd16443532fb9e3b97
  CHECKSUM(SHA256) upstream package :
5edabb76e10c24a44559ef7c52de24c2003860929926a6fd16443532fb9e3b97


Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -n mirrorbrain --prebuilt
Buildroot used: fedora-19-x86_64
Active plugins: Generic, Python, Shell-api, C/C++
Disabled plugins: Java, SugarActivity, Perl, R, PHP, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]