https://bugzilla.redhat.com/show_bug.cgi?id=987738 --- Comment #7 from Christopher Meng <cickumqt@xxxxxxxxx> --- (In reply to František Dvořák from comment #6) > My observations: > > 1) description could be improved > > Inspiration can be found in upstream: > http://anonscm.debian.org/gitweb/?p=collab-maint/dput.git;a=blob;f=debian/ > control;hb=HEAD . Thanks, anonscm sometimes can't be accessed. I will change the description later. > 4) missing build requires python2-devel or python3-devel > > Here it is not so clear, what to do with it. > > There are *.py and *.pyc files in /usr/share/dput/, and this directory > doesn't distinguish the python version. Proper directory could be > %{python_sitelib} or %{python3_sitelib}, but these files are used as > "plugins" and the code expects them in /usr/share/dput. Am I right these > files should remain there? (I'm not python programmer.) > > I that case it could be just used python-devel as the build dependency (= > using default python BR). Well, I don't think this is a problem. This is not a python module, can't be used in system-wide, so we don't need to store it under python_sitelib, see my another package "git-cola". Do you want to review it? ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review