[Bug 1032108] Review Request: yarock - A Lightweight and Beautiful Music Player

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1032108



--- Comment #45 from James Abtahi <jamescategory@xxxxxxxxx> ---
> In any case, the directory containing the translations needs to be listed in
> %files with a %dir tag, e.g.:
> %dir %{_datadir}/locale/%{name}/

Thanks a lot for this solution. Saved me from a lot of headaches. I've added it
to the new spec.

> 2. Whats the status of upstreaming the patches? It's usually good
> practice to add comments next to any patches in the spec with links
> to any upstream bug reports, or even just a 'sent to upstream on yyyy-mm-dd'

Done. I sent the patches to upstream and added comments to the spec file. I
also fixed that little "coverart" typo in description.

updated SPEC:
http://jam3s.fedorapeople.org/yarock.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]