[Bug 1036254] Review Request: hamster-time-tracker - The Linux time tracker

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1036254



--- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
Hi Antonio,

Thank you for the review!

(In reply to Antonio Trande from comment #1)
> - The '/usr/share/appdata' and '/usr/share/gnome/help' directories are not
> owned.
> They are co-owned by some "no-core" packages. I think both directories can be
> owned even by this package.   

I'll update this. 

I can't find what package owns /usr/share/gnome/help at all:

[asinha@ankur-laptop  ~]$ rpm -qf /usr/share/gnome/help/
file /usr/share/gnome/help is not owned by any package

Each package owns it's directory, but no one owns this? Probably a packaging
bug somewhere. 

> 
> - 'non-conffile-in-etc' warnings should be fixed

I'll look into this. The gconf schema doesn't need to be marked as %config from
the looks of it since they aren't configuration files that a user can manually
edit.

Same for the bash completion directiory. It isn't marked as a config directory:
http://pkgs.fedoraproject.org/cgit/bash-completion.git/tree/bash-completion.spec


> 
><snip>
> 
> Issues:
> =======
> - GConf schemas are properly installed
>   Note: gconf file(s) in hamster-time-tracker
>   See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GConf

^ Are they properly installed, or improperly installed? I mean, is the way I've
handled it wrong? I did get all those scriptlets from the wiki page itself. 

> - Package contains BR: python2-devel or python3-devel

The package doesn't contain this. Does this need to be added?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]