https://bugzilla.redhat.com/show_bug.cgi?id=1034523 Kashyap Chamarthy <kchamart@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kchamart@xxxxxxxxxx --- Comment #3 from Kashyap Chamarthy <kchamart@xxxxxxxxxx> --- Yes, agreed with Christopher Meng's comments, please address them, some more comments below: * The reasoning for s/python/python2 is here: http://fedoraproject.org/wiki/Packaging:Python#Macros -- "The unversioned macro, %{__python} is deprecated. You should use %{__python2} to explicitly reference the python2 interpreter instead. This is future proofing for the time when things will be switched over to python3 by default instead of python2." * You need a sponsor (I notice you raised FE-NEEDSPONSOR). I'm not one. But I can review the package. Just for reference: http://fedoraproject.org/wiki/How_to_sponsor_a_new_contributor * And, here are a few rpmlint failures: ========================= Rpmlint ------- Checking: sqlcli-1-1.fc20.noarch.rpm sqlcli-1-1.fc20.src.rpm sqlcli.noarch: W: summary-ended-with-dot C A SQL query utility. sqlcli.noarch: W: invalid-license GPL sqlcli.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/sqlcli/main.py 0644L /usr/bin/python sqlcli.noarch: W: no-manual-page-for-binary sqlcli sqlcli.src: W: summary-ended-with-dot C A SQL query utility. sqlcli.src: W: invalid-license GPL sqlcli.src: W: no-%build-section 2 packages and 0 specfiles checked; 1 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint sqlcli sqlcli.noarch: W: summary-ended-with-dot C A SQL query utility. sqlcli.noarch: W: invalid-license GPL sqlcli.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/sqlcli/main.py 0644L /usr/bin/python sqlcli.noarch: W: no-manual-page-for-binary sqlcli 1 packages and 0 specfiles checked; 1 errors, 3 warnings. # echo 'rpmlint-done:' ========================= -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review