https://bugzilla.redhat.com/show_bug.cgi?id=1034523 --- Comment #2 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. URL: https://github.com/larsks/sqlcli/ 2. BuildRequires: python --> BuildRequires: python2-devel 3. %{python_sitelib} --> %{python2_sitelib} 4. Better give a version(tag) on github. 5. %install > requirements.txt python setup.py install --root=$RPM_BUILD_ROOT --> %build %{__python2} setup.py build %install %{__python2} setup.py install --prefix=%{_prefix} -O1 --skip-build --root=%{buildroot} 6. %files section should be: %doc README.md %{_bindir}/sqlcli %{python_sitelib}/sqlcli-1-py*.egg-info %{python_sitelib}/sqlcli 7. No license file included as %doc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review