[Bug 1034492] Review Request: asciinema - Record and upload terminal sessions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1034492



--- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> ---
1. This package can be built under python2/3 simultaneously.

So it's better to name this package python-asciinema and build a python3
subpackage python3-asciinema.

BTW you can use source from pypi. The information above is also documented at
there.

https://pypi.python.org/pypi/asciinema

2. Because you've written:

BuildArch:    noarch

It's worthless to write:

CFLAGS="$RPM_OPT_FLAGS"

3. Remove %clean section and %defattr(-,root,root,-) in %files section

4. %{__python} --> %{__python2}

%{python_sitelib} --> %{python2_sitelib}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]