https://bugzilla.redhat.com/show_bug.cgi?id=1031437 --- Comment #5 from Gerard Ryan <gerard@xxxxxxx> --- Wonderful, thanks for the review and approval gil! (In reply to gil cattaneo from comment #4) > Thanks, for your changes! > non blocking issues: > [!]: If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %doc. Upstream has agreed to include it for next release onwards, so this won't be an issue. > [!]: License file installed when any subpackage combination is installed. > > please, add eclipse-1.0.txt for each sub package, berore import in SCM I've added it to the base ones, and every other subpackage depends on those, so it's "installed when any subpackage combination is installed." Is that enough or is it still necessary to have it for absolutely every subpackage anyway? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review