[Bug 1028521] Review Request: perl-DBD-ODBC - ODBC Driver for DBI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1028521



--- Comment #7 from Jan Holcapek <holcapek@xxxxxxxxx> ---
(In reply to Lubomir Rintel from comment #6)
> 0.) Please split a long line:
> 
> -%doc Changes FAQ if_you_are_taking_over_this_code.txt README README.adabas
> README.af README.hpux README.informix README.osx README.RH9 README.sqlserver
> README.unicode README.windows test_results.txt TO_DO
> +%doc Changes FAQ if_you_are_taking_over_this_code.txt
> +%doc README README.adabas README.af README.hpux README.informix
> ...
> 
> Also, are _all_ these files needed?

Well, they're not. Please have a look at the updated list.

> 1.) Please add required build dependencies:
> 
> Test::Pod::Coverage
> Test::Pod

Fixed.

> 2.) These are not runtime dependencies 
> 
> Requires:       perl(Test::Simple) >= 0.90
> Requires:       perl(Test::Version) >= 1.002001

Fixed.

> 3.) You may want to remove old RPM artifacts, at least for Rawhide
> 
> BuildRoot, %clean section and %defattrs are no longer needed

Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]