https://bugzilla.redhat.com/show_bug.cgi?id=1028521 --- Comment #6 from Lubomir Rintel <lkundrak@xxxxx> --- * Package named correctly * Latest stable version used * Package licensed correctly * License tag correct * SPEC file mostly clean and legible (see below) * Correct compiler flags used * Correct make flags used * Builds fine in mock (test dependencies missing, see below) * rpmlint happy * Filelist sane * Provides sane * Requires mostly sane (some extra, see below) 0.) Please split a long line: -%doc Changes FAQ if_you_are_taking_over_this_code.txt README README.adabas README.af README.hpux README.informix README.osx README.RH9 README.sqlserver README.unicode README.windows test_results.txt TO_DO +%doc Changes FAQ if_you_are_taking_over_this_code.txt +%doc README README.adabas README.af README.hpux README.informix ... Also, are _all_ these files needed? 1.) Please add required build dependencies: Test::Pod::Coverage Test::Pod 2.) These are not runtime dependencies Requires: perl(Test::Simple) >= 0.90 Requires: perl(Test::Version) >= 1.002001 3.) You may want to remove old RPM artifacts, at least for Rawhide BuildRoot, %clean section and %defattrs are no longer needed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review