https://bugzilla.redhat.com/show_bug.cgi?id=989847 Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |erik-fedora@xxxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #5 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> --- Hey Michael, My apologies for the late response. Been too busy with other stuff recently.. But let's continue with the review * rpmlint complains that the download url (to the svn snapshot) isn't available any more. Apparently SourceForge automatically purges (generated) svn snapshots from time to time.. As upstream hasn't done any new releases recently I think it would be better to add an additional comment to the spec file to indicate how the tarball can be reproduced. For inspiration, see the comment in http://pkgs.fedoraproject.org/cgit/mingw-headers.git/plain/mingw-headers.spec * When packaging SVN snapshots I personally find it more convenient when the revision number is also mentioned in the release tag (along with the snapshot date), so that for example you end up with Release: 1.0.svn20130812.r147%{?dist} I leave it up to you whether to use this convention or not * As mentioned by František above, the package doesn't build on mock due to a missing dependency on automake * The BuildRequires: mingw32-binutils mingw64-binutils is redundant (as they're already pulled in by mingw32-gcc and mingw64-gcc) so they can be removed * The 'cd plibc/' and 'mv COPYING ../' steps can be eliminated with these small changes: --- mingw-plibc.spec.orig 2013-11-17 17:36:24.980268511 +0100 +++ mingw-plibc.spec 2013-11-17 17:36:33.772418619 +0100 @@ -48,21 +48,18 @@ %prep -%setup -q -n plibc-code-147-trunk -%patch100 -p1 -b .mingw-include +%setup -q -n plibc-code-147-trunk/plibc +%patch100 -p2 -b .mingw-include %build -cd plibc/ sh ./bootstrap %mingw_configure %mingw_make %{?_smp_mflags} %install -cd plibc/ %mingw_make_install DESTDIR=$RPM_BUILD_ROOT -mv COPYING ../ # Drop all .la files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review