https://bugzilla.redhat.com/show_bug.cgi?id=989847 František Dvořák <valtri@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |valtri@xxxxxxxxxx --- Comment #4 from František Dvořák <valtri@xxxxxxxxxx> --- Several comments to the packaging: * missing build dependency on automake - mock complains "Can't exec "aclocal": No such file or directory" * it would be better to replace the "mv COPYING ../" command in %install by: - something like "cp -p plibc/COPYING ." in %prep - or using plibc/COPYING in %doc directly? * it seems sourceforge has some problems with the snapshot URL, maybe there could be added comment how to obtain the given version? Something like: # svn checkout -r 147 svn://svn.code.sf.net/p/plibc/code/trunk plibc-code-147-trunk * you can use %{summary} in the subpackages (just a tip, it is not needed :-)) * if I'm not mistaken, the release version could be simplified to "1.20130812svn%{?dist}", but there is no technical problem with the current scheme "1.0.20130812svn%{?dist}" (http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Post-Release_packages) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review