[Bug 1030073] Review Request: libtimezonemap - Time zone map widget for Gtk+

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1030073



--- Comment #2 from David Shea <dshea@xxxxxxxxxx> ---
(In reply to Christopher Meng from comment #1)
> 1. Better use macro consistently as:
> 
> Summary:        Development files for %{name}
> Requires:       %{name}%{?_isa} = %{version}-%{release}
> 
> %description    devel
> This package contains development files for
> developing applications that use %{name}.

Ok. Updated the spec and srpm on fedorapeople.

> 
> 2. 
> Rpmlint (installed packages)
> ----------------------------
> # rpmlint libtimezonemap libtimezonemap-devel
> libtimezonemap.i686: W: spelling-error %description -l en_US datetime ->
> date time, date-time, daytime

Intentional, this is referring a GNOME control-center panel named "datetime"

> libtimezonemap.i686: W: unused-direct-shlib-dependency
> /usr/lib/libtimezonemap.so.1.0.0 /lib/libpangocairo-1.0.so.0
> libtimezonemap.i686: W: unused-direct-shlib-dependency
> /usr/lib/libtimezonemap.so.1.0.0 /lib/libpango-1.0.so.0
> libtimezonemap.i686: W: unused-direct-shlib-dependency
> /usr/lib/libtimezonemap.so.1.0.0 /lib/libatk-1.0.so.0
> libtimezonemap.i686: W: unused-direct-shlib-dependency
> /usr/lib/libtimezonemap.so.1.0.0 /lib/libcairo-gobject.so.2

pango and cairo and other accouterments are pulled in by the gtk+ pkgconfig
whether they're used or not, so this is more gtk's fault than anything.

> libtimezonemap-devel.i686: W: no-documentation

Yeah. I'd like this package to include some API documentation generated from
doc comments, but right now there are no doc comments. Working with upstream on
getting those in place.

> 2 packages and 0 specfiles checked; 0 errors, 6 warnings.
> # echo 'rpmlint-done:'
> 
> 
> 3. GPL (v2 or later)
> -----------------
> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0.
> 4.1/src/cc-timezone-map.c
> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0.
> 4.1/src/cc-timezone-map.h
> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0.
> 4.1/src/tz.c
> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0.
> 4.1/src/tz.h
> 
> GPL (v3)
> --------
> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0.
> 4.1/src/timezone-completion.c
> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0.
> 4.1/src/timezone-completion.h
>

I updated the spec file to use GPLv3 as the license. I'll ask upstream if they
want to change the boilerplate on the stuff inherited from GNOME to GPLv3, but
since it's already v2 or later I don't think it should be an issue as-is.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]