[Bug 1030073] Review Request: libtimezonemap - Time zone map widget for Gtk+

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1030073

Christopher Meng <cickumqt@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |cickumqt@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |cickumqt@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> ---
1. Better use macro consistently as:

Summary:        Development files for %{name}
Requires:       %{name}%{?_isa} = %{version}-%{release}

%description    devel
This package contains development files for
developing applications that use %{name}.

2. 
Rpmlint (installed packages)
----------------------------
# rpmlint libtimezonemap libtimezonemap-devel
libtimezonemap.i686: W: spelling-error %description -l en_US datetime -> date
time, date-time, daytime
libtimezonemap.i686: W: unused-direct-shlib-dependency
/usr/lib/libtimezonemap.so.1.0.0 /lib/libpangocairo-1.0.so.0
libtimezonemap.i686: W: unused-direct-shlib-dependency
/usr/lib/libtimezonemap.so.1.0.0 /lib/libpango-1.0.so.0
libtimezonemap.i686: W: unused-direct-shlib-dependency
/usr/lib/libtimezonemap.so.1.0.0 /lib/libatk-1.0.so.0
libtimezonemap.i686: W: unused-direct-shlib-dependency
/usr/lib/libtimezonemap.so.1.0.0 /lib/libcairo-gobject.so.2
libtimezonemap-devel.i686: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 6 warnings.
# echo 'rpmlint-done:'


3. GPL (v2 or later)
-----------------
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0.4.1/src/cc-timezone-map.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0.4.1/src/cc-timezone-map.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0.4.1/src/tz.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0.4.1/src/tz.h

GPL (v3)
--------
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0.4.1/src/timezone-completion.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0.4.1/src/timezone-completion.h

------------------

PACKAGE APPROVED.

Can you fix 3 issues above? Or notify upstream?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]