[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=736717



--- Comment #32 from Orion Poplawski <orion@xxxxxxxxxxxxx> ---
Thank you for putting in the effort to address the linking issues and working
with upstreams - it is really appreciated.

The libdl dep should be handled like other library dep - a true/false macro
should be added to the AC_CHECK_LIB() call (see the call for crypto a little
below) to set a DL_LIBS variable which would only be added to those link lines
that need it.  Although I'm not seeing any more unused lib dep rpmlint messages
myself on F20, so I'm not sure it is necessary.

FWIW - If you still want to target EPEL5, you'll need BuildRoot and %clean.  If
not, I would drop the conditionals for %{rhel}<=5.

Finally - are you *sure* you want to keep the -devel packages as noarch? 
Michael has pointed out some of the drawbacks to that, and the gains are very
little.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]