[Bug 1027770] Review Request: ocserv - OpenConnect SSL VPN server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1027770



--- Comment #8 from Alec Leamas <leamas.alec@xxxxxxxxx> ---
(In reply to Nikos Mavrogiannopoulos from comment #7)
> (In reply to Alec Leamas from comment #5)
>
> > Thou shall not use %makeinstall [1]
> I don't this it was used. I was using %make_install.
Oops, sorry, my bad. Need new glasses, it seems.

> 
> > You have a lot of licenses, not just GPLv2 such as GPLv3+, LGPL, LGPL2.1 and
> > X11. Use  the licensecheck tool to get the complete story, and look into [2]
> > to write a proper license tag. 
> 
> Well, the library used that has the LGPLv3, GPLv3 license options (libopts)
> is also available under simplified BSD (COPYING.mbsd), so GPLv3 or even
> LGPLv3 don't apply here. I only install the mbsd license to make that clear.
> So overall the package is under GPLv2+.

I attach the licenses list as produced by fedora-review. At a glance it looks
like the license after promoting LGPL nd GPLv2+ would be (GPLv3 and MIT). Could
you please comment on this?

Here are also some bad FSF addresses, see [1] for handling.

More important:  It seems that here is a bundling issue: Some of the files with
Public Domain "license" seems to be from [2]. As this is a defined upstream,
these files should be unbundled [3].

Other bundled files seems to be from the libopts library. Here is probably
more, these was just the first I found.

It might be that these files are actrually not used in the build. IN this case
they should be removed in %prep  [4].

[1] https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
[2] http://burtleburtle.net/bob/
[3] https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
[4] https://fedoraproject.org/wiki/Packaging:Treatment_Of_Bundled_Libraries

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]