https://bugzilla.redhat.com/show_bug.cgi?id=1027770 --- Comment #7 from Nikos Mavrogiannopoulos <nmavrogi@xxxxxxxxxx> --- (In reply to Alec Leamas from comment #5) Thanks for the nice comments. I've addressed them (all except the first). > I'm no sponsor, but I noticed some issues (there are certainly more) while > skimming through your spec: > First, there are some things which are not needed unless you intend to use > this on EPEL. If not, just remove them: > - rm -rf %{buildroot} > - %clean (whole section) > - %defattr(-,root,root,-) > OTOH, if you are heading for EPEL you need a Buildroot: tag. I'm not sure whether I want that or not :) I left it for now and added the Buildroot tag. > Is the BuildRequires: autogen really needed? Unfortunately yes. > Thou shall not use %makeinstall [1] I don't this it was used. I was using %make_install. > You have a lot of licenses, not just GPLv2 such as GPLv3+, LGPL, LGPL2.1 and > X11. Use the licensecheck tool to get the complete story, and look into [2] > to write a proper license tag. Well, the library used that has the LGPLv3, GPLv3 license options (libopts) is also available under simplified BSD (COPYING.mbsd), so GPLv3 or even LGPLv3 don't apply here. I only install the mbsd license to make that clear. So overall the package is under GPLv2+. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review