[Bug 1025601] Review Request: python-pypump - Python Pump.io library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1025601

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m



--- Comment #2 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
(In reply to Mosaab Alzoubi from comment #1)
> * License GPLv3

Have a look at this:

$ licensecheck -r *
docs/conf.py: GENERATED FILE
docs/examples/pypump-post-note.py: *No copyright* UNKNOWN
pypump/exception/PumpException.py: *No copyright* UNKNOWN
pypump/exception/DoesNotExist.py: *No copyright* UNKNOWN
pypump/exception/ImmutableException.py: *No copyright* UNKNOWN
pypump/exception/__init__.py: *No copyright* UNKNOWN
pypump/exception/ServerError.py: *No copyright* UNKNOWN
pypump/pypump.py: GPL (v3 or later)
pypump/__init__.py: *No copyright* UNKNOWN
pypump/models/comment.py: GPL (v3 or later)
pypump/models/image.py: GPL (v3 or later)
pypump/models/activity.py: GPL (v3 or later)
pypump/models/person.py: GPL (v3 or later)
pypump/models/feed.py: GPL (v3 or later)
pypump/models/__init__.py: GPL (v3 or later)
pypump/models/location.py: GPL (v3 or later)
pypump/models/collection.py: GPL (v3 or later)
pypump/models/note.py: GPL (v3 or later)
pypump/openid.py: GPL (v3 or later)
pypump/compatability.py: GPL (v3 or later)
setup.py: *No copyright* UNKNOWN

Don't refer to the license file only. In doubt, have a look at the file headers
to see if the "later versions" clause has to be applied.


> * Using docs/ folder as documents in both python-pypump and python3-pypump
> without making them !

Indeed, the docs contain the "docs" folder as it is. If you want to add those
contents to the package, proceed the Makefile to get real content.

> * Must use %__python2 macro instead of %__python.
See also https://bugzilla.redhat.com/show_bug.cgi?id=1025368#c1.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]