https://bugzilla.redhat.com/show_bug.cgi?id=1025601 Mosaab Alzoubi <moceap@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |moceap@xxxxxxxxxxx --- Comment #1 from Mosaab Alzoubi <moceap@xxxxxxxxxxx> --- I'm not a packager yet, but these information may help. ------------------------- Package PRE-Review : * License GPLv3 * Using docs/ folder as documents in both python-pypump and python3-pypump without making them ! There are alot of choises : html to make standalone HTML files dirhtml to make HTML files named index.html in directories singlehtml to make a single large HTML file pickle to make pickle files json to make JSON files htmlhelp to make HTML files and a HTML help project qthelp to make HTML files and a qthelp project devhelp to make HTML files and a Devhelp project epub to make an epub latex to make LaTeX files, you can set PAPER=a4 or PAPER=letter latexpdf to make LaTeX files and run them through pdflatex text to make text files man to make manual pages texinfo to make Texinfo files info to make Texinfo files and run them through makeinfo gettext to make PO message catalogs changes to make an overview of all changed/added/deprecated items linkcheck to check all external links for integrity doctest to run all doctests embedded in the documentation (if enabled) That will be nice if some of them (html,man..) maked. * Must use %__python2 macro instead of %__python. * Source in SRPM match upstream one. 197a6bbb604edda02390f23bb7cc817a. * Spec and contents is clean. * Rpmlint almost clean : rpmlint -i /run/media/moceap/MULTIBOOT/1025601-python-pypump/srpm/python-pypump-0.4-1.fc19.src.rpm python-pypump.src: W: spelling-error Summary(en_US) io -> oi, Io, ii The value of this tag appears to be misspelled. Please double-check. python-pypump.src: W: spelling-error %description -l en_US io -> oi, Io, ii The value of this tag appears to be misspelled. Please double-check. python-pypump.src: W: spelling-error %description -l en_US pythonic -> Python, python The value of this tag appears to be misspelled. Please double-check. python-pypump.src: W: invalid-url URL: http://pypi.python.org/pypi/PyPump timed out The value should be a valid, public HTTP, HTTPS, or FTP URL. 1 packages and 0 specfiles checked; 0 errors, 4 warnings. * To solve URL warning use HTTPS instead HTTP. * Builds succeed in Fedora 19 i686 (using updates-testing repo). * No bundels. == -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review