[Bug 1026380] Review Request: corebird - Native GTK Twitter client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1026380



--- Comment #6 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
Created attachment 820077
  --> https://bugzilla.redhat.com/attachment.cgi?id=820077&action=edit
Git diff patch.

I'll go ahead and review the newer version. One nitpick, certainly not a
blocker:

Upstream forgot to bump the about-dialog version before tagging and did it in
subsequent commits:

* 003bee4 - (2 days ago) about dialog: 0.3 -> 0.4 — Timm Bäder
* 42c0373 - (2 days ago) pkgbuild: Change _realver to 0.4 — Timm Bäder
* 7b82914 - (2 days ago) readme: Remove ubuntu/fedora librsvg dependencies —
Timm Bäder (tag: 0.4)

Can you look to incorporate the two tiny changes (patch attached)? I think a
simple sed command in %prep will do it. Or, you can use a tarball from this
commit (this might be overkill).

Users might get confused when they see a difference in version between the
about dialog and rpm -q output.

Detailed review coming up shortly. 

Thanks,
Warm regards,
Ankur

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]